Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info on session resource & getOne domain method #63

Merged
merged 7 commits into from
Oct 16, 2018

Conversation

ronan-gloo
Copy link
Contributor

@ronan-gloo ronan-gloo commented Oct 16, 2018

Reason for this PR

  • We need to completely implement the /me resource in order to get info internally
  • The domain resource does not provides direct acres to identified resource

Added

  • SessionResource::getId() : provides the account id associated to the token
  • SessionResource::getRoles() : provides an array of named roles associated to the token
  • SessionResource::getLanguageTag() : provides the language tag associate to the token
  • AbstractDomainResource::getOne($id) : allow to directly get a resource for the domain
  • HalLink::withAddedHref(string $path) : Allow to creates new instance of link with concatenated path

Bug fixes

  • InventoryDomain::getByReference() was not checking for NULL resource

@ronan-gloo ronan-gloo added the enhancement New feature or request label Oct 16, 2018
@ronan-gloo ronan-gloo added this to the v0.3 milestone Oct 16, 2018
@ronan-gloo ronan-gloo self-assigned this Oct 16, 2018
@ronan-gloo ronan-gloo requested a review from ddattee October 16, 2018 08:04
@ronan-gloo ronan-gloo changed the base branch from master to develop October 16, 2018 08:44
@ronan-gloo ronan-gloo merged commit d6c21e1 into develop Oct 16, 2018
@ronan-gloo ronan-gloo deleted the session-info-more branch October 16, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant